Skip to content

fix(versioned): Consistently use .into() in enum variant From impls #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

fix(versioned): Consistently use .into() in enum variant From impls #1109

merged 2 commits into from
Oct 22, 2025

Conversation

@Techassi
Copy link
Member

@Techassi Techassi commented Oct 22, 2025 •
edited
Loading

Needed for stackabletech/secret-operator#626. Similar code like below currently produces invalid code.

#[versioned(version(name = "v1alpha1"), version(name = "v1alpha2"))]
pub mod versioned {
    enum Bar {
        #[versioned(changed(since = "v1alpha2", from_name = "PrevA"))]
        A(A),
        B {},
    }

    struct A;
}

@Techassi Techassi self-assigned this Oct 22, 2025
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering Oct 22, 2025
@Techassi Techassi changed the title fix(versioned): Consitently use .into() in enum variant From impls fix(versioned): Consistently use .into() in enum variant From impls Oct 22, 2025
@Techassi Techassi marked this pull request as ready for review October 22, 2025 14:25
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Oct 22, 2025
@Techassi Techassi mentioned this pull request Oct 22, 2025
Merged
@sbernauer
Copy link
Member

sbernauer commented Oct 22, 2025 •
edited
Loading

Thanks for adopting the test!

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 22, 2025
@Techassi Techassi added this pull request to the merge queue Oct 22, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Oct 22, 2025
Merged via the queue into main with commit cfffa6c Oct 22, 2025
8 checks passed
@Techassi Techassi deleted the fix/stackable-versioned-from-impl-enum-into-fns branch October 22, 2025 15:03
@Techassi Techassi mentioned this pull request Oct 23, 2025
Merged
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@Techassi Techassi

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Techassi @sbernauer